Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#65 project setting #66

Merged
merged 13 commits into from
Dec 25, 2023
Merged

Feature/#65 project setting #66

merged 13 commits into from
Dec 25, 2023

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Dec 21, 2023 •
edited
Loading

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • login ๋ชจ๋“ˆ ๋ถ„๋ฆฌ
  • Feature ๋ชจ๋“ˆ ๋ถ„๋ฆฌ
  • Jetpack - Navigation
  • Snackbar
  • crashlytics ์„ค์ •
  • backup rules ์„ค์ •

๐ŸŒฑ PR ํฌ์ธํŠธ

  • Snackbar๋Š” mutex๋กœ ์ฒ˜๋ฆฌํ•˜์—ฌ ๋ˆ„๋ฝ๋˜์ง€ ์•Š๊ฒŒ ์ฒ˜๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค.

[NEW!!]

  • list, set, map์€ ์ปดํฌ์ฆˆ์—์„œ unstableํ•˜๋‹ค๊ณ  ํŒ๋‹จํ•˜๊ธฐ ๋•Œ๋ฌธ์— kotlinx-immutable-collection ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • Compose Compiler Reports๋ฅผ ์ด์šฉํ•ด stable, unstable ์—ฌ๋ถ€๋ฅผ report ๊ฒฐ๊ณผ๋กœ ๋ฐ›์•„๋ณผ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ๋งํฌ์˜ Compose Compiler Reports ๋ถ€๋ถ„์„ ์ฐธ๊ณ ํ•ด์ฃผ์„ธ์š”.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
image

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@jinukeu jinukeu requested review from lsakee and BEEEAM-J December 21, 2023 06:34
@jinukeu jinukeu self-assigned this Dec 21, 2023
BEEEAM-J
BEEEAM-J reviewed Dec 23, 2023
View reviewed changes
data/user/src/main/java/com/suwiki/data/user/datasource/RemoteUserDataSource.kt
suspend fun findPassword(
loginId: String,
email: String,
)

suspend fun resetPassword(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resetPassword ๋Š” login ๋ชจ๋“ˆ๋กœ ๋ถ„๋ฆฌํ•˜์ง€ ์•Š์€ ์ด์œ ๊ฐ€ ๋ญ”๊ฐ€์š”???
login ๋ชจ๋“ˆ๋กœ ๋ถ„๋ฆฌ๋˜๋Š” ๊ธฐ์ค€์„ ์ž˜ ๋ชจ๋ฅด๊ฒ ๋„ค์šฉ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

login ๋ชจ๋“ˆ์—๋Š” ๋กœ๊ทธ์ธ์— ํ•„์š”ํ•œ ๊ธฐ๋Šฅ๋งŒ ๋“ค์–ด๊ฐ€๊ฒŒ ํ–ˆ์Šต๋‹ˆ๋‹ค!
resetPassord๋Š” ๋กœ๊ทธ์ธ ์ดํ›„์— ๋™์ž‘ํ•˜๋Š” ๊ธฐ๋Šฅ์ด๊ธฐ์— ๋ถ„๋ฆฌํ•˜์ง€ ์•Š์•˜์–ด์š”~!!

BEEEAM-J
BEEEAM-J reviewed Dec 23, 2023
View reviewed changes
feature/navigator/src/main/java/com/suwiki/feature/navigator/MainScreen.kt Outdated
.selectable(
selected = selected,
indication = null,
role = null,
Copy link
Member

@BEEEAM-J BEEEAM-J Dec 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์š”๊ฑฐ ๊ผญ ํ•„์š”ํ•œ ์ธ์ž์ธ๊ฐ€์š”??
์ฐพ์•„๋ดค๋Š”๋ฐ ์ด๊ฑฐ์— ๋Œ€ํ•œ ๊ฐœ๋…์ด ์ž˜ ์ดํ•ด๊ฐ€ ์•ˆ๋˜์„œ ์งˆ๋ฌธํ•ฉ๋‹ˆ๋‹ค..!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ—› ... ์ง€๊ธˆ ๋ณด๋‹ˆ ํ•„์š”์—†์–ด๋ณด์ด๋„ค์š”!
์•„์˜ˆ suwikiClickable๋กœ ๊ต์ฒดํ–ˆ์Šต๋‹ˆ๋‹ค!

BEEEAM-J
BEEEAM-J approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@BEEEAM-J BEEEAM-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!! ๐Ÿ‘๐Ÿ‘
์•„์ง ์ „์ฒด์ ์ธ ํ”„๋กœ์ ํŠธ ๊ตฌ์กฐ๊ฐ€ ์ต์ˆ™ํ•˜์ง€ ์•Š์•„์„œ ๋ฆฌ๋ทฐํ•˜๋Š”๋ฐ ์ข€ ์˜ค๋ž˜ ๊ฑธ๋ ธ๋„ค์š”...ใ…Žใ…Ž

@jinukeu
Copy link
Member Author

jinukeu commented Dec 23, 2023

[NEW!!]

  • list, set, map์€ ์ปดํฌ์ฆˆ์—์„œ unstableํ•˜๋‹ค๊ณ  ํŒ๋‹จํ•˜๊ธฐ ๋•Œ๋ฌธ์— kotlinx-immutable-collection ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • Compose Compiler Reports๋ฅผ ์ด์šฉํ•ด stable, unstable ์—ฌ๋ถ€๋ฅผ report ๊ฒฐ๊ณผ๋กœ ๋ฐ›์•„๋ณผ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ๋งํฌ์˜ Compose Compiler Reports ๋ถ€๋ถ„์„ ์ฐธ๊ณ ํ•ด์ฃผ์„ธ์š”.

๋ช‡ ๊ฐ€์ง€ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋‹ค์‹œ ์ฝ”๋ฆฌ ๋ถ€ํƒ๋“œ๋ฆด๊ฒŒ์š”

@jinukeu jinukeu requested a review from BEEEAM-J December 23, 2023 10:40
lsakee
lsakee approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@BEEEAM-J
Copy link
Member

์ถ”๊ฐ€๋œ ๋‚ด์šฉ๊นŒ์ง€ ๋‹ค ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค! ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค~~~

@jinukeu jinukeu merged commit c345127 into develop Dec 25, 2023
1 check passed
@jinukeu jinukeu deleted the feature/#65-project-setting branch January 8, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsakee lsakee lsakee approved these changes

@BEEEAM-J BEEEAM-J Awaiting requested review from BEEEAM-J

Assignees

@jinukeu jinukeu

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] Project Setting
3 participants
@jinukeu @BEEEAM-J @lsakee